Pass avro reader schema for SMB operation #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
smb-avro-file-op-reader-schema
branch
from
453579f
to
883f793
Compare
RustedBones
commented
Oct 17, 2023
| @@ -210,7 +203,7 @@ public void prepareRead(ReadableByteChannel channel) throws IOException { | |||
| // same as SpecificRecordDatumFactory in scio-avro | |||
| ReflectData data = new ReflectData(recordClass.getClassLoader()); | |||
| org.apache.beam.sdk.extensions.avro.schemas.utils.AvroUtils.addLogicalTypeConversions(data); | |||
| datumReader = new ReflectDatumReader<>(data); | |||
There was a problem hiding this comment.
schema was not passed to the reader
clairemcginty
approved these changes
Oct 17, 2023
kellen
approved these changes
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #5032 +/- ##
=======================================
Coverage 63.12% 63.12%
=======================================
Files 286 286
Lines 10736 10736
Branches 764 764
=======================================
Hits 6777 6777
Misses 3959 3959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in #4975. Schema is not given to the reflect datum reader.