Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voyager support in Scio #4996

Merged
merged 28 commits into from
Oct 10, 2023
Merged

Voyager support in Scio #4996

merged 28 commits into from
Oct 10, 2023

Commits on Sep 15, 2023

  1. wip

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    cfcd55d View commit details
    Browse the repository at this point in the history

  2. WIP

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    d3f2149 View commit details
    Browse the repository at this point in the history

  3. next steps

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8fef885 View commit details
    Browse the repository at this point in the history

  4. start fleshing out reader as well

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    d3257b0 View commit details
    Browse the repository at this point in the history

  5. basic testing done

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    16cc3e5 View commit details
    Browse the repository at this point in the history

  6. updates galore

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    47e9bcb View commit details
    Browse the repository at this point in the history

  7. copyrights

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7290bee View commit details
    Browse the repository at this point in the history

  8. add in updates

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a3a14b3 View commit details
    Browse the repository at this point in the history

  9. Update w/ multi pathing might revert it out though

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2923e00 View commit details
    Browse the repository at this point in the history

  10. Add in refactor + updates to get working for reading indicies

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9f5a170 View commit details
    Browse the repository at this point in the history

  11. add in doc strings

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5dcbc52 View commit details
    Browse the repository at this point in the history

  12. bump voyager version

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2975d76 View commit details
    Browse the repository at this point in the history

  13. fix formatting issues

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6a965fa View commit details
    Browse the repository at this point in the history

  14. Address feedback

    Patrick McGee committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    95b6614 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. add in more docs

    Patrick McGee committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3d277cd View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. coder updates

    Patrick McGee committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d14ad20 View commit details
    Browse the repository at this point in the history

  2. Add in the update to rfu to make it work w/ magnolia

    Patrick McGee committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ad91a87 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Update scio-extra/src/main/scala/com/spotify/scio/extra/voyager/packa… 

    …ge.scala

Co-authored-by: Claire McGinty <claire.d.mcginty@gmail.com>
    @patrickwmcgee @clairemcginty
    patrickwmcgee and clairemcginty authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    3f73295 View commit details
    Browse the repository at this point in the history

  2. Address more feedback

    Patrick McGee committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    08a56fb View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Apply suggestions from code review

    @clairemcginty
    clairemcginty authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    0694a77 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Fix integration tests

    @RustedBones
    RustedBones committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5d2b586 View commit details
    Browse the repository at this point in the history

  2. Reorganize code to respect scio structure

    @RustedBones
    RustedBones committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    85a203e View commit details
    Browse the repository at this point in the history

  3. add headers

    @clairemcginty
    clairemcginty authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    fc0c868 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Remove RemoteFileUtil from model

    @RustedBones
    RustedBones committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ce8c1ce View commit details
    Browse the repository at this point in the history

  2. Share VoyagerReader side-input cache

    @RustedBones
    RustedBones committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    72cc431 View commit details
    Browse the repository at this point in the history

  3. Add missing dep in compile

    @RustedBones
    RustedBones committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    96003e6 View commit details
    Browse the repository at this point in the history

  4. Rollback RemoteFileUtil equality definition

    @RustedBones
    RustedBones committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ed82684 View commit details
    Browse the repository at this point in the history

  5. Fix API and doc

    @RustedBones
    RustedBones committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8a4d84b View commit details
    Browse the repository at this point in the history