Drop deprecated sbt IntegrationTest configuration
#4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
changed the title
IntegrationTest configuration
RustedBones
force-pushed
the
integration-test
branch
from
f53562e
to
fc3607e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4971 +/- ##
=======================================
Coverage 63.42% 63.42%
=======================================
Files 288 288
Lines 10807 10807
Branches 785 785
=======================================
Hits 6854 6854
Misses 3953 3953 ☔ View full report in Codecov by Sentry. |
RustedBones
force-pushed
the
integration-test
branch
from
908acc9
to
13458cd
Compare
RustedBones
commented
Aug 31, 2023
| @@ -19,7 +19,8 @@ jobs: | |||
| distribution: temurin | |||
| java-version: 11 | |||
| - run: > | |||
| sbt "; headerCheckAll; javafmtCheckAll; scalafmtCheckAll; scalafmtSbtCheck" | |||
| sbt "; scalafmtSbtCheck; javafmtCheckAll; scalafmtCheckAll; headerCheckAll" | |||
| "; integration/javafmtCheckAll; integration/scalafmtCheckAll; integration/headerCheckAll" | |||
There was a problem hiding this comment.
integration module is not aggregated on purpose
RustedBones
commented
Aug 31, 2023
| @@ -24,4 +24,4 @@ jobs: | |||
| - name: set JVM opts | |||
| run: scripts/gha_setup.sh | |||
| - name: Run Dataflow jobs | |||
| run: sbt ${{ env.SBT_OPTS }} "scio-examples/IntegrationTest/runMain com.spotify.scio.examples.RunPreReleaseIT --runId=${{ github.run_id }}" | |||
| run: sbt ${{ env.SBT_OPTS }} "scio-examples/Test/runMain com.spotify.scio.examples.RunPreReleaseIT --runId=${{ github.run_id }}" | |||
There was a problem hiding this comment.
left the RunPreReleaseIT in scio-examples to not add this non scio module dependency to integration
clairemcginty
approved these changes
Aug 31, 2023
RustedBones
force-pushed
the
integration-test
branch
from
13458cd
to
2c34c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4862