Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey-patch BigtableIO for 0.9.5.1 #495 #497

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

andrewsmartin
Copy link
Contributor

No description provided.

@nevillelyh
Copy link
Contributor

Rename BigtableIO to PatchedBigtableIO in case any class loading issue?
Also does this work with the test job?

@codecov-io
Copy link

codecov-io commented Mar 17, 2017

Codecov Report

Merging #497 into master will decrease coverage by 81.91%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #497       +/-   ##
=========================================
- Coverage   81.91%     0%   -81.92%     
=========================================
  Files          72     62       -10     
  Lines        2731     67     -2664     
  Branches      303      5      -298     
=========================================
- Hits         2237      0     -2237     
+ Misses        494     67      -427
Impacted Files Coverage Δ
...src/main/scala/com/spotify/scio/extra/Breeze.scala 0% <0%> (-100%)
...la/com/spotify/scio/values/TransformNameable.scala 0% <0%> (-100%)
...otify/scio/coders/JIterableWrapperSerializer.scala 0% <0%> (-100%)
...om/spotify/scio/values/SCollectionWithFanout.scala 0% <0%> (-100%)
.../scala/com/spotify/scio/coders/AvroBytesUtil.scala 0% <0%> (-100%)
...n/scala/com/spotify/scio/coders/KVSerializer.scala 0% <0%> (-100%)
...cala/com/spotify/scio/coders/CoderSerializer.scala 0% <0%> (-100%)
...ala/com/spotify/scio/testing/TestDataManager.scala 0% <0%> (-100%)
...otify/scio/values/SCollectionWithAccumulator.scala 0% <0%> (-100%)
...m/spotify/scio/util/FunctionsWithAccumulator.scala 0% <0%> (-100%)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6288e1c...1afdbea. Read the comment docs.

@andrewsmartin
Copy link
Contributor Author

Decided against renaming -> PatchedBigqueryIO because this class passes this references to other API calls which expect BigqueryIO.

@nevillelyh
Copy link
Contributor

👍

@andrewsmartin andrewsmartin merged commit 90d9af1 into master Mar 18, 2017
@andrewsmartin andrewsmartin deleted the andrew/bigtable-patch branch March 18, 2017 01:23
@regadas
Copy link
Contributor

regadas commented Mar 23, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants