Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeValidation in TransformOverride #4967

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

RustedBones
Copy link
Contributor

Cherry-pick from #4962

Fix #4963

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4967 (6cb0fd8) into main (a39d157) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6cb0fd8 differs from pull request most recent head 1753687. Consider uploading reports for the commit 1753687 to get more accurate results

@@           Coverage Diff           @@
##             main    #4967   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files         282      282           
  Lines       10648    10649    +1     
  Branches      761      761           
=======================================
+ Hits         6717     6718    +1     
  Misses       3931     3931           
Files Changed Coverage Δ
...a/com/spotify/scio/testing/TransformOverride.scala 100.00% <100.00%> (ø)

@RustedBones RustedBones added this to the 0.13.3 milestone Aug 30, 2023
@RustedBones RustedBones merged commit dd3e9f3 into main Aug 31, 2023
10 checks passed
@RustedBones RustedBones deleted the fix-type-validation branch August 31, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransformOverride runtime typeValidation in wrong order
2 participants