Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-use ReflectData in AvroCoder #4951

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

clairemcginty
Copy link
Contributor

Addresses concurrency issue with encoding Avro records at scale -- we suspect the root cause is concurrent access of the shared ReflectData singleton.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4951 (86db7bd) into main (0429f43) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 86db7bd differs from pull request most recent head c26d0fb. Consider uploading reports for the commit c26d0fb to get more accurate results

@@            Coverage Diff             @@
##             main    #4951      +/-   ##
==========================================
- Coverage   63.10%   63.09%   -0.02%     
==========================================
  Files         282      282              
  Lines       10649    10646       -3     
  Branches      765      769       +4     
==========================================
- Hits         6720     6717       -3     
  Misses       3929     3929              
Files Changed Coverage Δ
...com/spotify/scio/coders/instances/AvroCoders.scala 85.71% <100.00%> (-0.96%) ⬇️

@clairemcginty clairemcginty merged commit 57f564c into main Aug 16, 2023
11 checks passed
@clairemcginty clairemcginty deleted the reflect-data-reuse branch August 16, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants