Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group grpc transforms #4879

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Group grpc transforms #4879

merged 2 commits into from
Jun 20, 2023

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Jun 13, 2023

Group grpc transform operations so they are nested inside a single block

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #4879 (8e1ced1) into main (c62da3a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 8e1ced1 differs from pull request most recent head b0643d7. Consider uploading reports for the commit b0643d7 to get more accurate results

@@            Coverage Diff             @@
##             main    #4879      +/-   ##
==========================================
+ Coverage   62.84%   62.87%   +0.02%     
==========================================
  Files         282      282              
  Lines       10573    10581       +8     
  Branches      795      795              
==========================================
+ Hits         6645     6653       +8     
  Misses       3928     3928              
Impacted Files Coverage Δ
...cala/com/spotify/scio/grpc/SCollectionSyntax.scala 100.00% <100.00%> (ø)

@RustedBones
Copy link
Contributor Author

Only snyk check failing but there was no dependency changes.

@RustedBones RustedBones requested a review from a team June 15, 2023 10:19
@RustedBones RustedBones added this to the 0.13.0 milestone Jun 15, 2023
@RustedBones RustedBones merged commit 3239e2a into main Jun 20, 2023
@RustedBones RustedBones deleted the grpc-transform branch June 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants