Fix dependency issues #4876
Merged
Fix dependency issues #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RustedBones
commented
Jun 13, 2023
•
RustedBones
commented
- ship direct runner for testing
- move gcs-connector to examples runtime dependency
- fix google api services storage version not in sync with google library_bom
Codecov Report
@@ Coverage Diff @@
## main #4876 +/- ##
=======================================
Coverage 62.85% 62.85%
=======================================
Files 282 282
Lines 10603 10603
Branches 775 775
=======================================
Hits 6665 6665
Misses 3938 3938 |
RustedBones
force-pushed
the
fixup-0.13-release
branch
2 times, most recently
from
9422fd7
to
51e40f8
Compare
RustedBones
commented
Jun 15, 2023
build.sbt
Outdated
| @@ -1182,6 +1183,7 @@ lazy val `scio-examples`: Project = project | |||
| "org.scala-lang.modules" %% "scala-collection-compat" % scalaCollectionCompatVersion, | |||
| "org.slf4j" % "slf4j-api" % slf4jVersion, | |||
| // runtime | |||
| "com.google.cloud.bigdataoss" % "gcs-connector" % s"hadoop2-$bigdataossVersion", | |||
There was a problem hiding this comment.
@clairemcginty this used to be shipped with scio-parquet. I feel we should stay agnostic to the storage system and this must be manually added by users if needed now.
RustedBones
force-pushed
the
fixup-0.13-release
branch
from
9bcaed6
to
1c65655
Compare
RustedBones
force-pushed
the
fixup-0.13-release
branch
from
d415fe5
to
2b752a4
Compare
kellen
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.