Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup context from fanout API #4873

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Cleanup context from fanout API #4873

merged 1 commit into from
Jun 13, 2023

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Jun 12, 2023

Part of #4459

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #4873 (4c08ee5) into main (1f32fd6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4c08ee5 differs from pull request most recent head 14e04de. Consider uploading reports for the commit 14e04de to get more accurate results

@@            Coverage Diff             @@
##             main    #4873      +/-   ##
==========================================
- Coverage   62.89%   62.89%   -0.01%     
==========================================
  Files         282      282              
  Lines       10574    10575       +1     
  Branches      773      781       +8     
==========================================
  Hits         6651     6651              
- Misses       3923     3924       +1     
Impacted Files Coverage Δ
...spotify/scio/values/PairSCollectionFunctions.scala 98.22% <100.00%> (ø)
...tify/scio/values/SCollectionWithHotKeyFanout.scala 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@RustedBones RustedBones merged commit 8810930 into main Jun 13, 2023
@RustedBones RustedBones deleted the cleanup-fanout branch June 13, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants