Documentation revamp #4871
Merged
Documentation revamp #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4871 +/- ##
==========================================
+ Coverage 62.89% 62.96% +0.06%
==========================================
Files 282 282
Lines 10574 10641 +67
Branches 773 779 +6
==========================================
+ Hits 6651 6700 +49
- Misses 3923 3941 +18
|
scio-jdbc/src/main/scala/com/spotify/scio/jdbc/sharded/JdbcShardedReadOptions.scala
Outdated
Show resolved
Hide resolved
RustedBones
reviewed
Jun 15, 2023
| @@ -57,7 +57,7 @@ final class PredictSCollectionOps[T](private val self: SCollection[T]) { | |||
| * @param signatureName | |||
| * name of [[org.tensorflow.framework.SignatureDef]] s to be used to run the prediction. | |||
| */ | |||
| def predict[V: Coder, W]( | |||
| def predict[V: Coder]( | |||
There was a problem hiding this comment.
This is a breaking change. would you like to mark this one for 0.13 ?
There was a problem hiding this comment.
Yeah let's. The parameter is unused so not sure why it lived on, maybe for backwards compatibility?
RustedBones
reviewed
Jun 15, 2023
| @@ -0,0 +1,102 @@ | |||
| # Side Inputs | |||
There was a problem hiding this comment.
Should we also add a section to discourage map on side input as the operation is a view and will be applied on every element accessing the side input ?
| @@ -0,0 +1,41 @@ | |||
| # AsyncDoFn | |||
RustedBones
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents a bunch of previously undocumented or only-scaladoced bits of scio functionality for the site. Also documents some fundamental features in a structured way.