Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala versions to 2.12.18 and 2.13.11 #4864

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Update scala versions to 2.12.18 and 2.13.11 #4864

merged 3 commits into from
Jun 13, 2023

Conversation

RustedBones
Copy link
Contributor

No description provided.

@RustedBones
Copy link
Contributor Author

RustedBones commented Jun 8, 2023

Tests are still failing with scala 2.13.11. See scala/bug#12683

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #4864 (6beeb35) into main (81f8316) will increase coverage by 0.12%.
The diff coverage is 84.74%.

❗ Current head 6beeb35 differs from pull request most recent head 6b927cf. Consider uploading reports for the commit 6b927cf to get more accurate results

@@            Coverage Diff             @@
##             main    #4864      +/-   ##
==========================================
+ Coverage   62.71%   62.84%   +0.12%     
==========================================
  Files         281      282       +1     
  Lines       10539    10572      +33     
  Branches      775      788      +13     
==========================================
+ Hits         6610     6644      +34     
+ Misses       3929     3928       -1     
Impacted Files Coverage Δ
...cala/com/spotify/scio/bigquery/BigQueryTypes.scala 68.00% <0.00%> (-1.39%) ⬇️
...io/bigquery/dynamic/syntax/SCollectionSyntax.scala 0.00% <ø> (ø)
...sdk/extensions/smb/ParquetTypeFileOperations.scala 96.55% <50.00%> (-3.45%) ⬇️
...otify/scio/bigquery/syntax/SCollectionSyntax.scala 72.72% <66.66%> (ø)
.../src/main/scala/com/spotify/scio/jdbc/JdbcIO.scala 76.81% <76.00%> (+5.14%) ⬆️
...ala/com/spotify/scio/testing/TransformFinder.scala 86.66% <86.66%> (ø)
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 50.27% <87.27%> (+9.30%) ⬆️
...y/scio/values/PairSkewedSCollectionFunctions.scala 99.18% <100.00%> (+2.33%) ⬆️
...ain/scala/com/spotify/scio/extra/json/JsonIO.scala 100.00% <100.00%> (ø)
...in/scala/com/spotify/scio/extra/json/package.scala 80.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@RustedBones
Copy link
Contributor Author

The regression should not be a blocker. We're not in control of user's scala version anyway. Those affected by the bug can downgrade.

@RustedBones RustedBones merged commit 195a34b into main Jun 13, 2023
@RustedBones RustedBones deleted the update-scala branch June 13, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant