Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set typed table description when using scio BQ client #4860

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Jun 6, 2023

Whne using client, we should have the same behavior as the typed BQ IO: using the @description annotation when creating the table

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #4860 (ba299c2) into main (eee089e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head ba299c2 differs from pull request most recent head 8341b67. Consider uploading reports for the commit 8341b67 to get more accurate results

@@            Coverage Diff             @@
##             main    #4860      +/-   ##
==========================================
- Coverage   62.53%   62.52%   -0.02%     
==========================================
  Files         281      281              
  Lines       10431    10433       +2     
  Branches      781      790       +9     
==========================================
  Hits         6523     6523              
- Misses       3908     3910       +2     
Impacted Files Coverage Δ
...la/com/spotify/scio/bigquery/client/BigQuery.scala 21.31% <0.00%> (-0.73%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (ø)

@RustedBones RustedBones requested a review from a team June 15, 2023 10:20
@RustedBones RustedBones merged commit eb49734 into main Aug 18, 2023
@RustedBones RustedBones deleted the bq-typed-table-description branch August 18, 2023 09:22
patrickwmcgee pushed a commit to patrickwmcgee/scio that referenced this pull request Sep 12, 2023
* Set typed table description when using scio BQ client

* Scalafmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants