Add a better worded exception of unsupported SpecificRecord coder case #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4815 +/- ##
==========================================
+ Coverage 62.40% 62.43% +0.03%
==========================================
Files 280 280
Lines 10407 10410 +3
Branches 760 781 +21
==========================================
+ Hits 6495 6500 +5
+ Misses 3912 3910 -2
|
RustedBones
reviewed
May 23, 2023
| s"Avro schema by instantiating $clazz. Use only a concrete type implementing " + | ||
| s"SpecificRecord or use GenericRecord type in your transformations if a concrete " + | ||
| s"type is not known in compile time." | ||
| throw new Throwable(msg, cause) |
There was a problem hiding this comment.
I think this isn't worth chaining the exception here, as the one raised by
SpecificData.get().getSchema(clazz)is already suppressed. We're already in a fallback/recover case.
There was a problem hiding this comment.
- my intuition is that this extra info won't hurt
- this would make clear if failure happens for anything other than "constructor not found", like
getSchemamight fail because of some bug in apache avro
There was a problem hiding this comment.
Ok. I'd also change the exception type with a IllegalArgumentException and if using the try/cath, prefer
case NonFatal(e) =>
instead of catching any Throwable
Comment on lines
148
to
149
| // Otherwise create a default instance and call getSchema | ||
| .getOrElse(getSchemaFromEmptyInstance) |
There was a problem hiding this comment.
orElse will make this more idiomatic IMHO
Suggested change
| // Otherwise create a default instance and call getSchema | |
| .getOrElse(getSchemaFromEmptyInstance) | |
| .orElse(Try(clazz.getDeclaredConstructor().newInstance().getSchema)) | |
| .getOrElse { | |
| val msg = ... | |
| throw new RuntimeException(msg) | |
| } |
RustedBones
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.