Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old skewed-join API #4808

Merged
merged 7 commits into from
Jun 7, 2023
Merged

Remove old skewed-join API #4808

merged 7 commits into from
Jun 7, 2023

Conversation

RustedBones
Copy link
Contributor

Part of #4459

@RustedBones RustedBones added this to the 0.13.0 milestone May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #4808 (cd7c6c1) into main (de5f3f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cd7c6c1 differs from pull request most recent head c5a8278. Consider uploading reports for the commit c5a8278 to get more accurate results

@@           Coverage Diff           @@
##             main    #4808   +/-   ##
=======================================
  Coverage   62.46%   62.47%           
=======================================
  Files         282      282           
  Lines       10412    10408    -4     
  Branches      776      774    -2     
=======================================
- Hits         6504     6502    -2     
+ Misses       3908     3906    -2     
Impacted Files Coverage Δ
...y/scio/values/PairSkewedSCollectionFunctions.scala 99.18% <100.00%> (+2.33%) ⬆️

... and 1 file with indirect coverage changes

@RustedBones RustedBones marked this pull request as draft May 30, 2023 12:03
@RustedBones RustedBones changed the title Deprecate old skewed-join API Remove old skewed-join API May 31, 2023
@RustedBones RustedBones marked this pull request as ready for review May 31, 2023 14:56
@RustedBones
Copy link
Contributor Author

@kellen added scalafix rule

@RustedBones RustedBones merged commit d0e2843 into main Jun 7, 2023
@RustedBones RustedBones deleted the deprecate-skewed-join branch June 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants