Relax avro record type bound #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
May 12, 2023
| Object obj = value; | ||
| for (Method getter : getOrInitGetters(keyPath, value.getClass())) { |
There was a problem hiding this comment.
This was wrong. We would return the 1st cached getter regardless if the key was the primary or the secondary
RustedBones
commented
May 12, 2023
Comment on lines
+49
to
+50
| @JsonIgnore private final AtomicReference<int[]> keyPath = new AtomicReference<>(); | ||
| @JsonIgnore private final AtomicReference<int[]> keyPathSecondary = new AtomicReference<>(); |
There was a problem hiding this comment.
We now have to delay the construction for those, as the schema is required to get access to the field index instead of the field name
Codecov Report
@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 60.67% 62.40% +1.72%
==========================================
Files 286 280 -6
Lines 10447 10405 -42
Branches 693 768 +75
==========================================
+ Hits 6339 6493 +154
+ Misses 4108 3912 -196
|
kellen
approved these changes
May 12, 2023
scio-smb/src/main/java/org/apache/beam/sdk/extensions/smb/AvroUtils.java
Show resolved
Hide resolved
RustedBones
force-pushed
the
relax-avro-record-type
branch
from
7ec2884
to
3d4b7ad
Compare
RustedBones
force-pushed
the
relax-avro-record-type
branch
from
17946a6
to
3d4b7ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4459
Also fixes a bug for 2nd key in parquet for scala model