Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Configuration initialization in scio-parquet #4791

Merged
merged 2 commits into from
May 3, 2023

Conversation

clairemcginty
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #4791 (6e6a868) into main (1620aec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6e6a868 differs from pull request most recent head 1ecbae4. Consider uploading reports for the commit 1ecbae4 to get more accurate results

@@           Coverage Diff           @@
##             main    #4791   +/-   ##
=======================================
  Coverage   61.25%   61.25%           
=======================================
  Files         286      286           
  Lines       10568    10570    +2     
  Branches      767      772    +5     
=======================================
+ Hits         6473     6475    +2     
  Misses       4095     4095           
Impacted Files Coverage Δ
...rquet/types/dynamic/syntax/SCollectionSyntax.scala 87.50% <ø> (ø)
.../com/spotify/scio/parquet/avro/ParquetAvroIO.scala 87.71% <100.00%> (ø)
...arquet/avro/dynamic/syntax/SCollectionSyntax.scala 92.30% <100.00%> (ø)
.../main/scala/com/spotify/scio/parquet/package.scala 71.42% <100.00%> (+2.19%) ⬆️
...ify/scio/parquet/tensorflow/ParquetExampleIO.scala 89.02% <100.00%> (ø)
.../tensorflow/dynamic/syntax/SCollectionSyntax.scala 88.88% <100.00%> (ø)
...com/spotify/scio/parquet/types/ParquetTypeIO.scala 98.59% <100.00%> (ø)

…cala

Co-authored-by: Michel Davit <micheld@spotify.com>
@clairemcginty clairemcginty merged commit 2c6130f into main May 3, 2023
@clairemcginty clairemcginty deleted the parquet_conf_defaults branch May 3, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants