Update beam to 2.46.0 #4744
Merged
Update beam to 2.46.0 #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4744 +/- ##
=======================================
Coverage 61.03% 61.03%
=======================================
Files 286 286
Lines 10527 10527
Branches 759 759
=======================================
Hits 6425 6425
Misses 4102 4102
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
clairemcginty
approved these changes
Mar 13, 2023
RustedBones
commented
Mar 14, 2023
| assembly / test := {}, | ||
| assembly / assemblyMergeStrategy ~= { old => | ||
| { | ||
| case PathList("org", "apache", "beam", "sdk", "extensions", "avro", _*) => |
There was a problem hiding this comment.
beam now ships the avro classes twice. IDK why they did not rename the package. in the future if the impl diverge, the class-loader will pick one at random and may fail
There was a problem hiding this comment.
According to the release notes, this is not a conflict with previous core avro.
Should double check what is conflicting here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.