Add hadoopDistCache - support all Hadoop filesystems #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls do not merge yet - i need to test |
| logger.debug(s"Add '$path' to dist cache") | ||
|
|
||
| val _conf = Option(conf).getOrElse(new Configuration()) | ||
| val target = new Path(self.options.getStagingLocation, path.split("/").last) |
There was a problem hiding this comment.
Maybe "$stagingLocation/distcache/$file" for better organization?
Also the filename part should include a random hash to avoid collision?
There was a problem hiding this comment.
Good idea about extra dir. initially I was thinking we could just overwrite files, but hash is probably better.
| val _conf = Option(conf).getOrElse(new Configuration()) | ||
|
|
||
| //TODO: should we add checksums on both src and GCS to reuse uploaded artifacts? | ||
| val path_hash = Hashing.sha1().hashString(path, Charsets.UTF_8) |
There was a problem hiding this comment.
camelCase, i.e. pathHash, targetHash, targetDistCache, etc.
Hadoop DistCache will first upload artifacts from source to GCS and use those via standard GCS based cache mechanism.
ravwojdyla
force-pushed
the
hdfs_cache
branch
2 times, most recently
from
7237102
to
5915d35
Compare
|
👍 Can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hadoopDistCache will first upload artifacts from source to GCS and use
those via standard GCS based cache mechanism.