Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Taps for SMB writes/transforms #5080

Closed
clairemcginty opened this issue Nov 17, 2023 · 1 comment
Closed

Support Taps for SMB writes/transforms #5080

clairemcginty opened this issue Nov 17, 2023 · 1 comment
Labels
enhancement New feature or request io
Milestone
0.14.0

Comments

@clairemcginty
Copy link
Contributor

The Scala bindings for SMB writes return a ClosedTap[Nothing] (1, 2). For Scio 0.14, it could be nice to finally support this -- maybe the tap type could be Map[BucketShardId, Seq[T]]?
@clairemcginty clairemcginty added the enhancement New feature or request label Nov 17, 2023
@clairemcginty clairemcginty added this to the 0.14.0 milestone Nov 17, 2023
@RustedBones RustedBones added the io label Dec 1, 2023
@clairemcginty
Copy link
Contributor Author

We can easily implement this as a tap in SortedBucketIO once #4962 is merged

clairemcginty added a commit that referenced this issue Jan 8, 2024
@clairemcginty
Support Tap for SMB writes (addresses #5080)
c1e399e
@clairemcginty clairemcginty mentioned this issue Jan 8, 2024
Merged
3 tasks
clairemcginty added a commit that referenced this issue Jan 8, 2024
@clairemcginty
Support Tap for SMB writes (addresses #5080)
c5d4408
clairemcginty added a commit that referenced this issue Jan 11, 2024
@clairemcginty
Support Tap for SMB writes (addresses #5080) (#5144)
dd5af6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request io
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
2 participants
@clairemcginty @RustedBones