Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run scio-repl from SBT #400

Closed
joelostlund opened this issue Jan 18, 2017 · 5 comments
Closed

Cannot run scio-repl from SBT #400

joelostlund opened this issue Jan 18, 2017 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@joelostlund
Copy link

joelostlund commented Jan 18, 2017

When I do the following:

➜  scio git:(master) sbt run
[info] Loading global plugins from /Users/joel/.sbt/0.13/plugins
[info] Loading project definition from /Users/joel/code/scio/project
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[info] Set current project to scio (in build file:/Users/joel/code/scio/)
[success] Total time: 0 s, completed Jan 18, 2017 1:52:54 PM

It does not start the SCIO repl anymore as described in https://github.com/spotify/scio/wiki/Scio-REPL#start-from-sbt-console-scala-211x-only

I suspect this to be a bug. Could you please help out?

@ravwojdyla ravwojdyla added bug Something isn't working help wanted labels Jan 18, 2017
@nevillelyh
Copy link
Contributor

scio-repl/runMain com.spotify.scio.repl.ScioShell works for me. Should we fix either build.sbt or the doc?

@ravwojdyla
Copy link
Contributor

build.sbt +1 it's probably some misconfiguration somewhere.

@ravwojdyla ravwojdyla self-assigned this Jan 18, 2017
@ravwojdyla
Copy link
Contributor

ravwojdyla commented Jan 18, 2017

If I add (to the root project):

  mainClass in Compile := (mainClass in scioRepl in Compile).value,
  fullClasspath in Compile ++= (fullClasspath in scioRepl in Compile).value,

and comment out the scala version check:

//run := run in Compile in scioRepl dependsOn sbtReplScalaVersionCheck,

it runs fine, need to double check if this is safe tho.

@nevillelyh
Copy link
Contributor

IMO maybe better documenting it and leave build.sbt alone. REPL is probably not the first thing that comes mind when people do sbt run. A bit counter intuitive.

ravwojdyla pushed a commit that referenced this issue Jan 18, 2017
@ravwojdyla
Copy link
Contributor

Users will have to look at the documentation regardless of the solution, #403 fixed this issue, so maybe for now let's keep it the way it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants