-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line options for skip and successful file #386
Conversation
Also I fixed a bug where the tracks file would contain multiple songs in one line: Since we use When we then append |
spotdl/spotdl.py
Outdated
@@ -193,7 +209,7 @@ def main(): | |||
if const.args.song: | |||
download_single(raw_song=const.args.song) | |||
elif const.args.list: | |||
download_list(text_file=const.args.list) | |||
download_list(tracks_file=const.args.list, skip_file=const.args.skip, write_successful_file=const.args.write_successful) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is really long. Best we break it into lines like:
download_list(tracks_file=const.args.list,
skip_file=const.args.skip,
write_successful_file=const.args.write_successful)
I left a minor comment but looks good to me overall. We could merge this once it has been addressed. |
You're right, that was quick copy and paste 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this. Thanks @linusg!
Closes #296.
Adding two command line flags:
-sk
/--skip
and-w
/--write-successful
. Both have the same format, so using the same file with both flags is possible:I.e. successfully downloaded tracks will land in
skip.txt
and thus being skipped directly when creating and downloading the track file again.