-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved README #361
Improved README #361
Conversation
Added pip install information to README and made metadata bullet list smaller.
README.md
Outdated
**This tool works only with Python 3.** | ||
:heavy_exclamation_mark: **This tool works only with Python 3.** | ||
|
||
`pip install spotdl` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this above the last paragraph of the "Installation" section.
For this command you should use block code, also for people who don't check the wiki let's make it pip3
directly:
$ pip3 install spotdl
vs
pip3 install spotdl
Otherwise, LGTM. Not sure what @ritiek thought about changing the list's appearance, I'm pretty sure we discussed this before; can't find it ATM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm fine with having displaying possible metadata fields in a single line. If anything, IMO it previously looked bloated. Thanks @sdhutchins!
I also pushed a note to check out the wiki page. |
fyi, @linusg, this should be ready to merge whenever you have time. |
Right, thanks for the reminder and contribution of course! |
I made some very subtle edits to the readme.