Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve proxy URL regex matching #2155

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Improve proxy URL regex matching #2155

merged 1 commit into from
Aug 19, 2024

Conversation

zigzag1001
Copy link
Contributor

@zigzag1001 zigzag1001 commented Aug 14, 2024

Improve proxy URL regex matching

Description

Changes the URL matching regex to accept user:password proxies as well as normal public proxies.
Also generally improves proper url and ip format checking
regex101 demonstration: https://regex101.com/r/iS6jF6/108

Related Issue

Motivation and Context

I have a private proxy server that has a user:password requirement, without this change spotdl does not accept such proxies

How Has This Been Tested?

Tested by following poetry instructions in the project contribution guide and using a previously rejected proxy url.
Also tested on regex101 as linked to above.

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@xnetcat xnetcat merged commit c8179e9 into spotDL:dev Aug 19, 2024
@xnetcat xnetcat mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants