Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserving local web-ui, added --force-update-gui option to force checkout a new copy of web ui #2117

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

karanbheda
Copy link
Contributor

Title

Preserving local web-ui, added --force-update-gui option to force checkout a new copy of web ui

Description

Problem

spotdl web --port <port_num> command downloads the web-ui code from Github and runs it on the specified port. However, the compiled web-ui always points to port 8080, causing API failures on local. This requires a manual port change in the local web-ui repo which gets refreshed on every web run.

Solution

Checking if web-ui folder already exists on local before pulling in a fresh checkout.
Added --force-update-gui option to force pull the ui repo

Related Issue

Motivation and Context

Helps me run the web ui on a different port without having to manually change the port numbers on every run

How Has This Been Tested?

Since this is such a small change, I just ran some manual tests and checked compilation still worked.

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Preserving local web-ui, added --force-update-gui option to force checkout a new copy of web ui
@xnetcat xnetcat changed the base branch from master to dev July 20, 2024 10:31
@xnetcat xnetcat merged commit ac5f990 into spotDL:dev Jul 20, 2024
0 of 10 checks passed
@xnetcat xnetcat mentioned this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local web-ui
2 participants