Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix milliseconds for song initialization #2028

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

egndz
Copy link
Contributor

@egndz egndz commented Feb 19, 2024

Fix milliseconds for song initialization

This PR adds a miliseconds to seconds conversion for song Initialization from missing data.

Related Issue

Fixes #2021

Motivation and Context

For the calculation of best match, we calculate the duration differences which both have to be in the same scale where as for some songs it is milliseconds and seconds. This PR ensures that we divide the duration_ms by 1000 to convert to seconds

How Has This Been Tested?

Tests were completed based on the song list defined in #2021

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@Silverarmor Silverarmor changed the base branch from master to dev February 22, 2024 03:29
@xnetcat xnetcat merged commit ac89a73 into spotDL:dev Feb 23, 2024
0 of 10 checks passed
@xnetcat xnetcat mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spotDL Downloads Predominantly Long Tracks Over 1 Hour
3 participants