Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade rapidfuzz to 2.0.15 #1543

Merged
merged 2 commits into from
Jun 25, 2022
Merged

upgrade rapidfuzz to 2.0.15 #1543

merged 2 commits into from
Jun 25, 2022

Conversation

maxbachmann
Copy link
Contributor

upgrade rapidfuzz to 2.0.15

Description

rapidfuzz 2.0.15 finally fixes the termux issues. I am not familiar with poetry. I did simply run poetry lock, but this removed some of the brotli wheels. How can this be avoided?

Related Issue

This fixes #1485

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Release V4 Release Candidate 1
@xnetcat
Copy link
Member

xnetcat commented Jun 24, 2022

Hmm, maybe try this

Revert changes in poetry.lock

poetry remove rapidfuzz
poetry add rapidfuzz>=2.0.15

But If tests are successful it doesn't matter ig

@xnetcat
Copy link
Member

xnetcat commented Jun 24, 2022

Also can you fix black warning?

@xnetcat
Copy link
Member

xnetcat commented Jun 24, 2022

Is #1542 related to new rapidfuzz version in any way?

@maxbachmann
Copy link
Contributor Author

poetry remove rapidfuzz
poetry add rapidfuzz>=2.0.15

this had the same outcome

Also can you fix black warning?

sure fixed the warning

Is #1542 related to new rapidfuzz version in any way?

This is an issue fixed in jarowinkler==1.0.4, so this issue is fixed by this pr as well.

@xnetcat xnetcat changed the base branch from master to dev June 25, 2022 06:02
@Silverarmor Silverarmor merged commit 4cf3301 into spotDL:dev Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: Could not build wheels for cmake, ninja, which is required to install pyproject.toml-based projects
3 participants