Update the song name matching rules in YouTube music #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the test failed. |
Tests are broken, and I don't have time to fix them. Code looks fine |
xnetcat
pushed a commit
that referenced
this pull request
May 11, 2022
lukaszb
pushed a commit
to lukaszb/spotify-downloader
that referenced
this pull request
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Update the song name matching rules in YouTube music
Description
Song name matching rules are too strict after matching ISRC code in youtube music. For example a song called
Setting Fires - BOXINBOX & Lionsize Remixin Spotify, but calledSetting Fires (BOXINBOX & Lionsize Remix)in YouTube Music.I tested 200 songs and this is my playlist：
https://open.spotify.com/playlist/4OJx800ojOiUCqhL8WRfCQ
https://open.spotify.com/playlist/75DbXkdkz166RgqaomP32E
I found this helped me find the correct version of a dozen songs that were in the wrong version，and the other correct version search results don't change
Related Issue
#1517
Motivation and Context
Improves the probability of downloading the correct version of a song
How Has This Been Tested?
I tested 200 songs and this is my playlist：
https://open.spotify.com/playlist/4OJx800ojOiUCqhL8WRfCQ
https://open.spotify.com/playlist/75DbXkdkz166RgqaomP32E
Screenshots (if appropriate)
Types of Changes
Checklist