Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1433 #1434

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Fix #1433 #1434

merged 2 commits into from
Dec 13, 2021

Conversation

s1as3r
Copy link
Contributor

@s1as3r s1as3r commented Dec 13, 2021

Fix #1433

Description

Since spotdl uses os.chdir to change the download location, providing
a relative path as an argument to --ffmpeg causes it to look for ffmpeg
in the incorrect location, i.e arguments.ffmpeg realtive to the directory we
change to.

The fix is simple, use absolute path to ffmpeg before we change the working directory.

Related Issue

#1433

How Has This Been Tested?

pytest (python 3.9)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@s1as3r s1as3r added the Bug Fix PRs that fix bugs label Dec 13, 2021
@s1as3r s1as3r requested a review from xnetcat December 13, 2021 14:59
*sigh*
effin whitespace again
@xnetcat xnetcat merged commit 5463024 into spotDL:dev Dec 13, 2021
@s1as3r s1as3r deleted the fix-ffmpeg branch December 13, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants