Handle YouTube results without links #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silverarmor
approved these changes
Jul 18, 2021
Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>
Coddo-Python
pushed a commit
to Coddo-Python/spotify-downloader-pafy-redesign
that referenced
this pull request
Jul 25, 2021
* Handle YouTube results without links * Update spotdl/search/audioProvider.py Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>
Merged
Silverarmor
added a commit
that referenced
this pull request
Jul 28, 2021
* added ability to override youtube url (#1338) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> * Handle YouTube results without links (#1340) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> * restructured project; various bugfixes and improvements (#1339) Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Montel Edwards <m@monteledwards.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Handle YouTube results without links
Description
handles results without 'link' provided by skipping them.
This pr is based on @MikhailZex commit. I am opening PR since he is busy rn
Related Issue
#1337
Motivation and Context
some YouTube results (isrcResult, audioProvider.pyL:170) do not even
contain 'link' as a key. This case is not handled and will error out.
How Has This Been Tested?
pytest
Screenshots (if appropriate)
Types of Changes
Checklist