Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use the output parameter using spotdl sync #1564

Closed
Piripe opened this issue Jul 26, 2022 · 7 comments
Closed

Can't use the output parameter using spotdl sync #1564

Piripe opened this issue Jul 26, 2022 · 7 comments
Assignees
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed

Comments

@Piripe
Copy link
Contributor

Piripe commented Jul 26, 2022

System OS

Windows

Python Version

3.10 (CPython)

Install Source

GitHub

Install version / commit hash

4.0.0rc2

Expected Behavior vs Actual Behavior

Output parameter didn't work using spotdl sync. (Also other parameters didn't work like bitrate or config)
I would like to use the output parameter because some musics are made by the same artist with the same title but not the same album (And it break my music library)

Steps to reproduce - Ensure to include actual links!

  1. Sync an artist
  2. See the problem if the artist have two musics called the same but not in the same album
  3. Try to change the output parameter
  4. See how it didn't work using spotdl sync

Traceback

SpotDL works completely fine lol

Other details

No response

@Piripe Piripe added the Bug Unexpected problem or unintended behavior that needs to be fixed label Jul 26, 2022
@Piripe Piripe changed the title Change this title, poorly formatted issues will not be handled Can't use the output parameter using spotdl sync Jul 26, 2022
@fer-hnndz
Copy link
Contributor

Just to be clear, --output does not work as intended when using spotdl sync?

@Piripe
Copy link
Contributor Author

Piripe commented Jul 28, 2022

Yep, that's right

@fer-hnndz
Copy link
Contributor

fer-hnndz commented Jul 28, 2022

Well, I was running some tests, and this is what I did:

  1. Run spotdl sync [a playlist url] --save-file sync.spotdl on my documents folder inside a test_songs folder.
  2. Remove a song from the playlist and run spotdl sync sync.spotdl --output "C:\Users\My Username\Desktop\Tests

The updated playlist was indeed downloaded in the specified path. Not sure if that is what you were trying to do when you found the bug. If you could tell me more details that would be very appreciated.

@Piripe
Copy link
Contributor Author

Piripe commented Jul 28, 2022

I want to use the output parameter as file name format. (To organize my musics in multiple folders)

I'm using this command line spotdl sync musics.sync.spotdl --output "{artist}/{album}/{title}.{output-ext}" --bitrate 320k

I also mentioned in my initial post that the bitrate parameter wasn't work. (The output files are in 128k)

@Mikec78660
Copy link

I want to use the output parameter as file name format. (To organize my musics in multiple folders)

I'm using this command line spotdl sync musics.sync.spotdl --output "{artist}/{album}/{title}.{output-ext}" --bitrate 320k

I also mentioned in my initial post that the bitrate parameter wasn't work. (The output files are in 128k)

I was having the same issue. It seems while it is read in the default is never getting updated. I didn't have a lot of time to figure out where it was going wrong but a temp fix is just update the default in:

https://github.com/spotDL/spotify-downloader/blob/master/spotdl/utils/config.py

to whatever you want and it will get used.

Silverarmor pushed a commit that referenced this issue Aug 19, 2022
* Clarify settings value priority

* remove default value for argument which have one

* Add a forgotten one

* Remove an unused and missing import from a test

* Still needs a const for flags options

Co-authored-by: Rokonio <naelkanada+git@gmail.com>
@Silverarmor
Copy link
Member

@Piripe
Can you please confirm if this has been fixed in rc3?

Update your spotDL to the latest release candidate:
python -m pip install -U pip pip install -U --force spotdl==4.0.0rc3

@Piripe
Copy link
Contributor Author

Piripe commented Aug 26, 2022

Yes, it's now working fine

@Piripe Piripe closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants