-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CI tests in Python SDK to Github Actions from TravisCI #399
Conversation
akaila-splunk
commented
Sep 24, 2021
- Added test.yml file for test cases execution on push and PR
- Remove .travis.yml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general these changes look good and I don't expect all tests to pass at this point but a number of the jobs are terminating with: Error: The operation was canceled.
could you possibly investigate those issues before merging this work? We'll also want to followup once we know which tests are failing and fix or skip those tests after investigating but that can be a followup task. For now I just want to make sure that all tests are being executed and not running into the above error.
- set fail-fast: false so GitHub will not cancels all in-progress jobs if any matrix job fails.
GitHub cancels all in-progress jobs with error |
Excellent, that's good to know - thanks for investigating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work - let's merge this. Can you also create a followup ticket to address the test failures now that we can see those? That will be high priority.
Sure, I'll create ticket for test failures. |