Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add input for scripted inputs os #296

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: add input for scripted inputs os #296

merged 1 commit into from
Jul 12, 2024

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Jul 10, 2024 •
edited
Loading

List of OSs for scripted inputes tests can be provided as an input to reusable workflow.
Tested: https://github.com/splunk/splunk-add-on-for-unix-and-linux/pull/577

@mkolasinski-splunk mkolasinski-splunk marked this pull request as ready for review July 10, 2024 14:55
@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner July 10, 2024 14:55
@mkolasinski-splunk mkolasinski-splunk changed the title chore: add input for scripted inputs os fix: add input for scripted inputs os Jul 10, 2024
@artemrys
Copy link
Member

What's the benefit of having it extracted?

@mkolasinski-splunk
Copy link
Contributor Author

mkolasinski-splunk commented Jul 10, 2024 •
edited
Loading

What's the benefit of having it extracted?

  1. When OSs for testing will get updated, they can be easily updated on TA side without a need to release a new version of reusable wf
  2. I like more having "constant/magic" values defined at the top of workflow

@mkolasinski-splunk mkolasinski-splunk merged commit 72497e5 into develop Jul 12, 2024
6 checks passed
@mkolasinski-splunk mkolasinski-splunk deleted the fix/input-value-for-os-scripted-inputs branch July 12, 2024 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys approved these changes

@kdoroszko-splunk kdoroszko-splunk kdoroszko-splunk approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkolasinski-splunk @artemrys @srv-rr-github-token @kdoroszko-splunk