Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype/inherited injection #361

Merged
merged 26 commits into from
Dec 16, 2020
Merged

Prototype/inherited injection #361

merged 26 commits into from
Dec 16, 2020

Conversation

vvval
Copy link
Member

@vvval vvval commented Dec 14, 2020

  • Fetch a list of all inherited injections
  • Merge injections and native dependencies in the correct order
  • Write corresponding tests
  • Fix none injection test

@vvval vvval marked this pull request as draft December 14, 2020 17:35
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #361 (5752d09) into master (7f3a9a3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #361      +/-   ##
============================================
+ Coverage     91.31%   91.35%   +0.04%     
- Complexity     8056     8089      +33     
============================================
  Files          1108     1108              
  Lines         27246    27344      +98     
============================================
+ Hits          24880    24981     +101     
+ Misses         2366     2363       -3     
Impacted Files Coverage Δ Complexity Δ
.../Prototype/tests/Commands/AbstractCommandsTest.php 78.94% <ø> (ø) 7.00 <0.00> (ø)
src/Prototype/src/Command/AbstractCommand.php 100.00% <100.00%> (ø) 17.00 <10.00> (+8.00)
src/Prototype/src/Command/InjectCommand.php 86.66% <100.00%> (+0.95%) 15.00 <1.00> (+1.00)
src/Prototype/src/Command/ListCommand.php 80.00% <100.00%> (ø) 3.00 <0.00> (ø)
...c/Prototype/src/NodeVisitors/UpdateConstructor.php 96.87% <100.00%> (+0.03%) 38.00 <1.00> (+1.00)
src/Prototype/tests/Commands/InjectCommandTest.php 100.00% <100.00%> (ø) 6.00 <2.00> (+2.00)
src/Prototype/tests/Fixtures/TestApp.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/Prototype/tests/InjectorTest.php 98.12% <100.00%> (ø) 16.00 <0.00> (ø)
src/Prototype/tests/Traverse/Extractor.php 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
src/Validation/tests/BaseTest.php 100.00% <0.00%> (ø) 6.00% <0.00%> (+3.00%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3a9a3...5752d09. Read the comment docs.

@vvval vvval marked this pull request as ready for review December 15, 2020 14:48
@vvval vvval merged commit 9eb6fbc into master Dec 16, 2020
@SerafimArts SerafimArts deleted the prototype/inherited_injection branch July 22, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prototype] Missing parent::__construct call for a child if a parent has trait usage
3 participants