Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spiral/core] Advanced Context Handling in Injector Implementations #1041

Merged
merged 7 commits into from
Jan 3, 2024

Don't resolve injector if constructor arguments are passed

b80910f
Select commit
Loading
Failed to load commit list.
Merged

[spiral/core] Advanced Context Handling in Injector Implementations #1041

Don't resolve injector if constructor arguments are passed
b80910f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2024 in 0s

89.49% (target 80.00%)

View this Pull Request on Codecov

89.49% (target 80.00%)

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dcb61c9) 89.51% compared to head (b80910f) 89.49%.
Report is 8 commits behind head on master.

Files Patch % Lines
src/Core/src/Internal/Factory.php 95.12% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1041      +/-   ##
============================================
- Coverage     89.51%   89.49%   -0.03%     
- Complexity     6234     6238       +4     
============================================
  Files           819      819              
  Lines         17555    17568      +13     
============================================
+ Hits          15714    15722       +8     
- Misses         1841     1846       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov