Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/tokenizer] Additional invocation of listeners in the booting event #1033

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 18, 2023

Q A
Bugfix?
Breaks BC?
New feature? ✔️

The invocation of listeners has been added to the booting event. Now, events added in the init method will be triggered earlier, during the booting event. And listeners added in the boot method will be triggered as before, during the booted event.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a38b50) 89.29% compared to head (a572721) 89.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1033   +/-   ##
=========================================
  Coverage     89.29%   89.29%           
+ Complexity     6211     6209    -2     
=========================================
  Files           817      817           
  Lines         17474    17474           
=========================================
+ Hits          15603    15604    +1     
+ Misses         1871     1870    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz marked this pull request as draft December 18, 2023 16:56
@msmakouz msmakouz marked this pull request as ready for review December 19, 2023 17:28
@butschster butschster merged commit 5ec6df0 into master Dec 21, 2023
13 of 14 checks passed
@butschster butschster deleted the feature/listeners-in-booting branch December 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants