Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations. #580

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix translations. #580

merged 1 commit into from
Apr 25, 2020

Conversation

Natim
Copy link
Member

@Natim Natim commented Apr 25, 2020

Refs #576

There are a couple of translations that seems broken to me.

@zorun
Copy link
Collaborator

zorun commented Apr 25, 2020

@Natim see #576, I think the whole page needs some overhauling to be able to translate it properly

@Natim Natim merged commit db47683 into master Apr 25, 2020
@Natim Natim deleted the i18n-strings-broken branch April 25, 2020 10:44
@Natim
Copy link
Member Author

Natim commented Apr 25, 2020

I think the whole page needs some overhauling to be able to translate it properly

Yeah that what I noticed, I tried to look at it, do you see things I missed?

@zorun
Copy link
Collaborator

zorun commented Apr 25, 2020

It's an improvement! But having things like <a href="#" data-toggle="modal" data-keyboard="false" data-target="#confirm-erase"> in the source to translate could break lots of things and even introduce XSS :/

There remains lots of strings that are handled through macros (simple_property_change, owers_changed) and it seems difficult.

Let's discuss on #576 about the best way to improve it and involve the original authors?

@Natim
Copy link
Member Author

Natim commented Apr 25, 2020

About HTML tags in the translation files, I believe that's the right way to do it.

I agree that weblate support for it is a bit weird. I like the way LingoHub handles it.

I think we can rely on review or tooling for the XSS matter.

For the macro I agree about involving original authors.

I translated it in French and it didn't seem too complex.

TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants