Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete python code (<3.6). #571

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Remove obsolete python code (<3.6). #571

merged 3 commits into from
Apr 24, 2020

Conversation

Natim
Copy link
Member

@Natim Natim commented Apr 24, 2020

No description provided.

@Natim Natim changed the title Remove # coding obsolete headers. Remove obsolete python code. Apr 24, 2020
@Natim Natim requested a review from Glandos April 24, 2020 07:43
@Natim Natim mentioned this pull request Apr 24, 2020
@Glandos
Copy link
Member

Glandos commented Apr 24, 2020

I personally love f-strings. They are cleaner, and on top of that, more performant at runtime.

But are we sure than we can expect all our user base to have python >= 3.6?

@Natim
Copy link
Member Author

Natim commented Apr 24, 2020

But are we sure than we can expect all our user base to have python >= 3.6?

Definitely yes. Python 3.5 endoflife is September 2020 and people can still use a previous version of I Hate Money in the meantime. Current Debian stable is Python 3.7

@Glandos
Copy link
Member

Glandos commented Apr 24, 2020

And Python3.6 is available in CentOS7. OK, let's go.

@Glandos Glandos changed the title Remove obsolete python code. Remove obsolete python code (<3.6). Apr 24, 2020
@Glandos Glandos merged commit 7587e29 into master Apr 24, 2020
@Glandos Glandos deleted the remove-py27-support branch April 24, 2020 10:32
@zorun
Copy link
Collaborator

zorun commented Apr 24, 2020

As I already said in #421 and #475, I'm a bit sad about dropping support for Python 3.5 while both Python 3.5 and Debian stretch are still maintained (until September 2020 for Python 3.5, and until June 2022 for Debian stretch). But at this point, buster has been out for 9 months already so it's less annoying. I guess I'll just have to finally upgrade my server ;)
This will of course need to go in the upgrade notes for IHM 5.0.

@Natim btw, you seem to have missed a reference to python 3.5 in docs/installation.rst

@zorun zorun added this to the v5 milestone Jul 17, 2020
@JocelynDelalande
Copy link
Contributor

Ouch, I missed the conversation about it.

A bit sad also, because as yunohost is still on stretch, and it will stop ihatemoney_ynh from receiving ihm upgrades for a while for little actual gain (except dev ease).

But go ahead, yunohost will upgrade to buster soon, and it seems that I am a few months late for such an objection :). My bad

JocelynDelalande added a commit to JocelynDelalande/ihatemoney that referenced this pull request Jul 26, 2020
Focus is on rebuilding venv (which are bound to a specific python minor
version).

Ref spiral-project#483
Ref spiral-project#571
zorun pushed a commit that referenced this pull request Jul 26, 2020
Focus is on rebuilding venv (which are bound to a specific python minor
version).

Ref #483
Ref #571
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
Focus is on rebuilding venv (which are bound to a specific python minor
version).

Ref spiral-project#483
Ref spiral-project#571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants