Added support to generate token of project #500
Conversation
| method_decorators = [need_auth] | ||
|
|
||
| def get(self, project): | ||
| print(project) |
There was a problem hiding this comment.
It seems that this print shouldn't be here :-)
There was a problem hiding this comment.
You are right!
| if not project: | ||
| return "Not Found", 404 | ||
| token = project.generate_token() | ||
| print(token) |
There was a problem hiding this comment.
you are right, only for testing
| restful_api.add_resource(ProjectsHandler, "/projects") | ||
| restful_api.add_resource(ProjectHandler, "/projects/<string:project_id>") | ||
| restful_api.add_resource(TokenHandler, "/token/<string:project_id>") |
There was a problem hiding this comment.
Should we put this at /projects/:id/token instead?
| headers={"Authorization": "Basic %s" % decoded_resp["token"]}, | ||
| ) | ||
|
|
||
| self.assertEqual(200, resp.status_code) |
There was a problem hiding this comment.
It seems to me that we should also test that the token can be used to login.
There was a problem hiding this comment.
Ok, I thought I was tested when the token was implemented
There was a problem hiding this comment.
It should have been, but my review was too weak :(
Thanks for your feedback it is very useful :) I don't know how to modify your fist advice "it seems that you also have code from your last pull request into this very one". I created the branch from a feature-request branch instead of master one. How can I change it? |
I believe the simplest way is to re-create a branch from master ( |
Now with endpoint /api/token/<project_id> you will get a {"token": "tokenofproject"} that you can use in GET "/api/project" with header "Authenthication: token ".
Hope it helps!
Issue: #412