Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bills with an amount of zero #1133

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

zorun
Copy link
Collaborator

@zorun zorun commented Jan 31, 2023

Bills with an amount of zero may be useful to remember that a transaction happened on a specific date, while the amount doesn't matter.

I use that with per-year projects when a reimbursement happens in year N but is relative to year N-1: I record it with an amount of zero in the project of year N, and with the real amount in the project of year N-1.

Besides, it's already possible to create such bills: while "0" is refused, "0.0" is accepted. There are no visible issues with this kind of bills.

@zorun zorun force-pushed the allow_zero_bills branch 3 times, most recently from 7abafd8 to 2d9257a Compare January 31, 2023 17:26
@zorun zorun requested a review from Glandos January 31, 2023 17:36
@Glandos
Copy link
Member

Glandos commented Feb 1, 2023

I've reviewed the history of this, and it's quite funny:

Go for it. It might be silly to some, but harmless anyway!

@zorun
Copy link
Collaborator Author

zorun commented Feb 2, 2023

Thanks for the historical perspective :D

I had to rebase, I will merge when the CI completes.

Bills with an amount of zero may be useful to remember that a transaction
happened on a specific date, while the amount doesn't matter.

I use that with per-year projects when a reimbursement happens in year N
but is relative to year N-1: I record it with an amount of zero in the
project of year N, and with the real amount in the project of year N-1.

Besides, it's already possible to create such bills: while "0" is refused,
"0.0" is accepted.  There are no visible issues with this kind of bills.
@zorun zorun merged commit 081f8dc into spiral-project:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants