-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSRF on logout #1040
Fix CSRF on logout #1040
Conversation
for now, there is nothing when /exit is called manually
It should be moved in its own preprocessor OR rename the current one
Thanks, the new approach looks good! Just to clarify, in the end you didn't implement a confirmation dialog? That's totally fine for me, I think logging out needs no confirmation. But you should maybe remove "confirm" in the name of the form ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me! Thanks for doing this maintenance work.
You're right: no confirmation, since this is far easier to code, and the UX is smoother. And you're right, I let the old name, it's meaningless now, so I renamed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything good for me, thanks!
Superseed #1028