Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of MySQL and replace it with MariaDB #743

Closed
almet opened this issue Apr 11, 2021 · 5 comments · Fixed by #775
Closed

Drop support of MySQL and replace it with MariaDB #743

almet opened this issue Apr 11, 2021 · 5 comments · Fixed by #775

Comments

@almet
Copy link
Member

almet commented Apr 11, 2021

So I'm wondering if we should drop support for MySQL in favor of MariaDB. MariaDB is now the default mysql implementation on Debian 10, and since Debian 9.

Since we're about to release a major version of IHM, it should make sense to drop MySQL altogether as we now have a good community-driven replacement, which also solves some bugs (#632 ) for us :-)

What do you think?

@Natim
Copy link
Member

Natim commented Apr 11, 2021

I'm not sure what you mean by dropping support. In my opinion MariaDB and MySQL may use the same driver, don't they?

@Natim
Copy link
Member

Natim commented Apr 11, 2021

Actually this might be related to #632 (comment)
I'm ok with dropping support then.

@almet
Copy link
Member Author

almet commented Apr 11, 2021

Yes, it's why I'm thinking about dropping support. In general, I don't think having a too wide support scope is a good idea.

@Glandos
Copy link
Member

Glandos commented Apr 16, 2021

I'm no longer a real user of MySQL/MariaDB, but yes, all major Linux distributions switched to MariaDB. So, yes, support only MariaDB is a good option for me too.

@zorun
Copy link
Collaborator

zorun commented Jul 4, 2021

I updated #631 to run the CI against mariadb, and I can confirm that mariadb 10.3.X passes all the tests.

So, I'm OK with dropping support for MySQL and requiring MariaDB >= 10.3.2. Debian buster satisfies this requirement; Debian stretch does not, but it is no longer supported anyway (because we stopped supporting Python 3.5)

I will prepare a PR to update documentation & release notes about this.

zorun pushed a commit to zorun/ihatemoney that referenced this issue Jul 4, 2021
Also document the new requirement for MariaDB >= 10.3.2

Fixes: spiral-project#632
Fixes: spiral-project#743
@zorun zorun closed this as completed in #775 Jul 5, 2021
zorun pushed a commit that referenced this issue Jul 5, 2021
Also document the new requirement for MariaDB >= 10.3.2

Fixes: #632
Fixes: #743
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this issue Mar 2, 2024
Also document the new requirement for MariaDB >= 10.3.2

Fixes: spiral-project#632
Fixes: spiral-project#743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants