Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): baking from another existing image #910

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

nemesisOsorio
Copy link
Member

  • Fixing azure baking for windows images
    • Producing a managed image instead a VHD(VHD will be deprecated, baking Linux images is already producing a managed image)
  • Migrating JSON templates to HCL (JSON templates will be deprecated)
  • Adding the option to bake from another existing image using:
    • publisher, offer and sku
    • another managed image

Related PRs

@spinnakerbot
Copy link
Contributor

We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:

  • rosco-core/src/main/groovy/com/netflix/spinnaker/rosco/providers/azure/util/AzureImageNameFactory.groovy

See our server-side commit conventions here.

"repository=${var.repository}", "package_type=${var.package_type}", "packages=${var.packages}",
"upgrade=${var.upgrade}"
]
pause_before = "20s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious: Is there a reason to set this to 20s instead of the old value 30s? I noticed it in the azure-linux.pkr.hcl as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no specific reason, I believe it is to give the VM the chance to be ready, 20s worked well, and I considered removing them even

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants