-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure): baking from another existing image #910
feat(azure): baking from another existing image #910
Conversation
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side commit conventions here. |
...est/groovy/com/netflix/spinnaker/rosco/providers/azure/util/AzureImageNameFactorySpec.groovy
Outdated
Show resolved
Hide resolved
"repository=${var.repository}", "package_type=${var.package_type}", "packages=${var.packages}", | ||
"upgrade=${var.upgrade}" | ||
] | ||
pause_before = "20s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just curious: Is there a reason to set this to 20s
instead of the old value 30s
? I noticed it in the azure-linux.pkr.hcl
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no specific reason, I believe it is to give the VM the chance to be ready, 20s worked well, and I considered removing them even
ab73981
to
577d399
Compare
Related PRs