refactor(jedis-test): replace use of io.spinnaker.embedded-redis:embe… #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded-redis with testcontainers so we no longer need to maintain https://github.com/spinnaker/embedded-redis and because after upgrading my mac to Sonoma (14.1), I see test failures with: Caused by: java.lang.RuntimeException: Can't start redis server. Check logs for details. at redis.embedded.AbstractRedisInstance.awaitRedisServerReady(AbstractRedisInstance.java:60) at redis.embedded.AbstractRedisInstance.start(AbstractRedisInstance.java:36) at redis.embedded.RedisServer.start(RedisServer.java:9) at com.netflix.spinnaker.kork.jedis.EmbeddedRedis.<init>(EmbeddedRedis.java:29) at com.netflix.spinnaker.kork.jedis.EmbeddedRedis.embed(EmbeddedRedis.java:65) at com.netflix.spinnaker.kork.jedis.EmbeddedRedis$embed.call(Unknown Source) The OS upgrade may not be the cause, but testcontainers works, and is generally a cleaner solution, so let's use it. Change the return value of getPool to the more specific JedisPool (from Pool<Jedis>) so it's useful by e.g. gate's RedisTestConfig class. Note that embedded-redis 0.9 was using version [4.0.10 of redis](https://github.com/spinnaker/embedded-redis/blob/v0.9.0/src/main/java/redis/embedded/RedisExecProvider.java#L30-L34). Use 5-alpine to match [fiat](https://github.com/spinnaker/fiat/blob/b64c9ea249bd262c84a7421faf071cabdd3fdf77/fiat-web/src/test/groovy/com/netflix/spinnaker/config/RedisContainerConfig.groovy#L35).
dbyron-sf
force-pushed
the
redis-with-testcontainers
branch
from
d20ffa7
to
35dbd04
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dded-redis with testcontainers
so we no longer need to maintain https://github.com/spinnaker/embedded-redis
and because after upgrading my mac to Sonoma (14.1), I see test failures with:
The OS upgrade may not be the cause, but testcontainers works, and is generally a cleaner solution, so let's use it.
Change the return value of getPool to the more specific JedisPool (from Pool) so it's useful by e.g. gate's RedisTestConfig class.
Note that embedded-redis 0.9 was using version 4.0.10 of redis. Use 5-alpine to match fiat.