Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to AMI and instance type validations, custom instance type selector #9793

Merged
merged 6 commits into from
Aug 25, 2022
Merged

Improvements to AMI and instance type validations, custom instance type selector #9793

merged 6 commits into from
Aug 25, 2022

Conversation

pdk27
Copy link
Contributor

@pdk27 pdk27 commented Dec 23, 2021 •
edited
Loading

Pre-req PRs:

spinnaker/clouddriver#5609

Changes:

  • Adding architecture to AWS image type
  • Adding instance type information to AWS instance type
  • Adding AmazonInstanceType to AmazonServerGroupCommand to make instance type info available
  • Improved validations / filtering of incompatible instance types:
    • new validation between AMI architecture and instance types' architecture
    • removed hard-coded instance family mapping for virtualization type validation, replaced with instance type info usage
    • added clarity around vpcOnly or ec2Classic validation

UI changes:

  • Displaying instance type info in Custom instance type selector in 2 places:
    • As a tooltip for already selected instance types
    • Enhanced drop down for list of available instance types
  • Adding filtering capability to the drop down in custom instance type selector. Filters implemented:
    • instance family / size / type e.g. c3/ large/ c3.large
    • min vcpu e.g. 16vcpu
    • min memory e.g 32gib
    • instance storage type e.g. ssd, hdd
    • spot support
    • ebs support
    • gpu support
    • current generation v/s old generation like 'currentGen' / 'oldGen'

Screenshots & Demo:

  • Demo
Demo.mov
  • Custom instance type select before changes

  • Help tooltip & drop down improvement

  • Filter Example & info for selected type

  • Filter Example

  • Filter Example

@pdk27
feat(aws): Adding validations between AMI architecture and instance t…
a409562 
…ypes

feat(aws): Changes to use instance types info
@pdk27
feat(aws): Improving custom instance type selection experience with i…
5972837 
…nstance type info, and links to examples/docs
@pdk27 pdk27 mentioned this pull request Dec 23, 2021
Merged
@mattgogerly
Copy link
Member

@Mergifyio update

@mattgogerly
Copy link
Member

@pdk27 is this ready to go?

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2022

update

✅ Branch has been successfully updated

@pdk27
Copy link
Contributor Author

pdk27 commented Aug 16, 2022

@pdk27 is this ready to go?

@mattgogerly I have a pre-requisite PR that needs to be merged in for these changes to work - spinnaker/clouddriver#5609

@pdk27 pdk27 removed the request for review from christopherthielen August 24, 2022 20:54
@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2022

update

✅ Branch has been successfully updated

@pdk27 pdk27 marked this pull request as ready for review August 25, 2022 15:17
@mattgogerly mattgogerly added the ready to merge Reviewed and ready for merge label Aug 25, 2022
@mergify mergify bot added the auto merged Merged automatically by a bot label Aug 25, 2022
@mergify mergify bot merged commit 8782045 into spinnaker:master Aug 25, 2022
@pdk27 pdk27 mentioned this pull request Aug 25, 2022
Merged
@link108 link108 mentioned this pull request Apr 17, 2023
Closed
link108 added a commit that referenced this pull request Apr 17, 2023
@pdk27 @link108 @mergify
Improvements to AMI and instance type validations, custom instance ty…
db9b4e3 
…pe selector (#9793)

choosing select files to backport

Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgogerly mattgogerly mattgogerly approved these changes

@caseyhebebrand caseyhebebrand caseyhebebrand approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pdk27 @mattgogerly @dbyron-sf @caseyhebebrand @spinnakerbot @link108