Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(azure): circular dependencies #6176

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(azure): circular dependencies #6176

merged 2 commits into from
Mar 28, 2024

Conversation

nemesisOsorio
Copy link
Member

@nemesisOsorio nemesisOsorio commented Mar 27, 2024 •
edited
Loading

Circular dependencies error when you enable azure

***************************                                                                                                            
APPLICATION FAILED TO START                                                                                                             
***************************                                                                                                             
                                                                                                                                        
Description:                                                                                                                            
                                                                                                                                        
The dependencies of some of the beans in the application context form a cycle:                                                          │
                                                                                                                                        │
┌──->──┐                                                                                                                                │
|  azureLoadBalancerProvider (field private com.netflix.spinnaker.clouddriver.azure.resources.loadbalancer.view.AzureLoadBalancerProvide│
r com.netflix.spinnaker.clouddriver.azure.resources.loadbalancer.view.AzureLoadBalancerProvider.azureLoadBalancerProvider)              │
└──<-──┘                                                                                                                                │

similar to spinnaker/gate#1780
fixes: spinnaker/spinnaker/issues/6935

@dbyron-sf
Copy link
Contributor

Any chance for adding a test for this...something like (at least because it uses ApplicationContextRunner) this?

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Mar 28, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Mar 28, 2024
@mergify mergify bot merged commit c530a1e into spinnaker:master Mar 28, 2024
23 checks passed
@nemesisOsorio nemesisOsorio mentioned this pull request Apr 9, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.34
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to start clouddriver
3 participants
@nemesisOsorio @dbyron-sf @spinnakerbot