Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appEngine): lazy init for App Engine beans for credentials #5749

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix(appEngine): lazy init for App Engine beans for credentials #5749

merged 1 commit into from
Jul 5, 2022

Conversation

nemesisOsorio
Copy link
Member

We are getting the following error

***************************
APPLICATION FAILED TO START
***************************

Description:

Field credentialsRepository in com.netflix.spinnaker.clouddriver.security.AbstractAtomicOperationsCredentialsConverter required a bean of type 'com.netflix.spinnaker.credentials.CredentialsRepository' that could not be found.

The injection point has the following annotations:
        - @org.springframework.beans.factory.annotation.Autowired(required=true)


Action:

Consider defining a bean of type 'com.netflix.spinnaker.credentials.CredentialsRepository' in your configuration.

there was a fix as well for Artifacts using CredentialsTypeBaseConfiguration class in https://github.com/spinnaker/clouddriver/pull/5203/files
Spring is not smart enough to identify dependencies in beans that are created in CredentialsTypeBaseConfiguration class

edgarulg
edgarulg approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@edgarulg edgarulg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dogonthehorizon dogonthehorizon added the ready to merge Approved and ready for a merge label Jul 5, 2022
@link108 link108 merged commit 010376c into spinnaker:master Jul 5, 2022
@link108
Copy link
Member

link108 commented Jul 5, 2022

@Mergifyio backport release-1.28.x

mergify bot pushed a commit that referenced this pull request Jul 5, 2022
@nemesisOsorio @mergify
fix(appEngine): lazy init for appengine beans for credentials (#5749)
76d8b7b 
(cherry picked from commit 010376c)
@mergify mergify bot mentioned this pull request Jul 5, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

backport release-1.28.x

✅ Backports have been created

link108 pushed a commit that referenced this pull request Jul 5, 2022
@mergify @nemesisOsorio
fix(appEngine): lazy init for App Engine beans for credentials (backp…
b1a4dda 
…ort #5749) (#5750)

Co-authored-by: nemesisOsorio <nemesis211_6@hotmail.com>
@nemesisOsorio nemesisOsorio mentioned this pull request Nov 11, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarulg edgarulg edgarulg approved these changes

@zachsmith1 zachsmith1 Awaiting requested review from zachsmith1 zachsmith1 is a code owner

Assignees
No one assigned
Labels
ready to merge Approved and ready for a merge target-release/1.29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nemesisOsorio @link108 @edgarulg @dogonthehorizon @spinnakerbot