fix(cf): scale app before building droplet

[mattgogerly]

Currently we set process config and scale the app/processes after building the droplet. This causes issues if the droplet requires more memory to build (e.g. lots of Python dependencies to install).

cf push uses a v2 endpoint to create applications which allows specifying scale when creating the app, whereas we are using a v3 endpoint which does not have those fields. Scaling is therefore a separate call.

[zachsmith1]

I'd recommend doing a push with the same Python stuff via the CLI and with the verbose flag. Also check the sequence of api calls. I vaguely remember we had to do it this way but we should prob do whatever the CLI does

[mattgogerly]

I'd recommend doing a push with the same Python stuff via the CLI and with the verbose flag. Also check the sequence of api calls. I vaguely remember we had to do it this way but we should prob do whatever the CLI does

The CF CLI is calling POST /v2/apps which accepts the full app definition (memory, disk, build packs etc). rather than v3, which we're calling, which only accepts the app name and lifecycle.

We've built an image with this change internally and we're able to deploy as normal with no issues, so if you have any idea what the specific problem was that we can test that'd be helpful!

edit: you might be thinking of the need to update processes before scaling, or to bind services before building the droplet? Both of those changes remain in place with this change

[nemesisOsorio]

@mattgogerly we checked the cli calls using version 8.3.0 this version is using API v3
we noticed the cli is calling POST /v3/packages follow by POST /v3/builds(droplet)
we used the command cf push nginx0001 -v --docker-image nginx:alpine
and then we scaled with cf scale nginx0001 -i 3
we are worried about the order of the api calls
just to clarify can you confirm that you deployed a docker image using these changes?
as well can you provide us an example of your pipeline?

[mattgogerly]

I don't have any way to test Docker stuff, which I assume means the issue @zachsmith1 pointed out is limited to that. Nonetheless, thanks for checking - I double checked and the /v3/builds endpoint has parameters for setting build sizing.

I've updated the PR to use those and reverted the ordering 👍

[nemesisOsorio]

LGTM, I believe you need to rename the pr

[link108]

@Mergifyio backport release-1.28.x

[mergify]

backport release-1.28.x

✅ Backports have been created

• #5710 fix(cf): scale app before building droplet (backport #5692) has been created for branch release-1.28.x