feat(docker): migrate to kork-credentials #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
nemesis-cruz-ar
force-pushed
the
feat/docker-kork-credentials
branch
from
83da1c2
to
f3420c8
Compare
There was a problem hiding this comment.
Thanks for adding kork credentials to docker provider! The changes look good, I only have minor comments.
I think the most important test is that for the same docker configuration, clouddriver behaves the same before and after this change, that is:
- Given two docker accounts with
cacheThreads: 2:- 4 docker agents should be created that run periodically (you can verify that those docker agents are running because every 30 seconds or so they should print logs like
.d.r.p.a.DockerRegistryImageCachingAgent : Caching 7231 tagged images in {account}/DockerRegistryImageCachingAgent[1/2] - 2 credentials of type
dockerRegistryshould be returned from/credentials
- 4 docker agents should be created that run periodically (you can verify that those docker agents are running because every 30 seconds or so they should print logs like
clouddriver-docker/src/main/java/com/netflix/spinnaker/config/DockerDefaultConfiguration.java
Outdated
Show resolved
Hide resolved
...aker/clouddriver/docker/registry/security/DockerRegistryCredentialsLifecycleHandlerTest.java
Show resolved
Hide resolved
|
demo for 2 accounts and 2 cache threads per account and credentials endpoint demo for deploying to cloudfoundry using a docker registry account |
Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
nemesis-cruz-ar
force-pushed
the
feat/docker-kork-credentials
branch
from
ceb0f33
to
399a8bf
Compare
german-muzquiz
approved these changes
Dec 14, 2021
3 tasks
kirangodishala
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
Sep 26, 2022
* feat(docker): migrate to kork-credentials Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> * feat(docker): addressing pull request comments Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
6 tasks
yugaa22
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
May 31, 2023
* feat(docker): migrate to kork-credentials Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> * feat(docker): addressing pull request comments Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
yugaa22
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
May 31, 2023
* feat(docker): migrate to kork-credentials Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> * feat(docker): addressing pull request comments Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
yugaa22
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
Sep 6, 2023
* feat(docker): migrate to kork-credentials Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> * feat(docker): addressing pull request comments Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
opsmxuser
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
Sep 6, 2023
* feat(docker): migrate to kork-credentials Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> * feat(docker): addressing pull request comments Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com> Co-authored-by: Sergio Quintero <sergio.quintero@armory.io> Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing kork-credentials for docker registry accounts similar to k8s, cloudfoundry, aws, and ecs accounts.
This is the implementation of https://github.com/spinnaker/governance/blob/master/rfc/account-management.md for docker registry provider.