ShellJob: Raise when < or > are specified in arguments
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stdout redirection is performed automatically by the `ShellJob` and the `metadata.options.filename_stdin` input should be used to redirect a particular file to stdin. Attempting to perform these redirections "manually" through the `arguments` input will fail as the symbols will be quoted and so interpreted as a literal command line argument. To prevent users making this mistake, a validator is added for the `arguments` input that validates that all elements are strings and that the reserved symbols are not defined.
sphuber
force-pushed
the
fix/023/validate-arguments-redirect-symbols
branch
from
2fd43f7
to
96e4357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Stdout redirection is performed automatically by the
ShellJoband themetadata.options.filename_stdininput should be used to redirect a particular file to stdin. Attempting to perform these redirections "manually" through theargumentsinput will fail as the symbols will be quoted and so interpreted as a literal command line argument.To prevent users making this mistake, a validator is added for the
argumentsinput that validates that all elements are strings and that the reserved symbols are not defined.