ShellJob: Customize the _build_process_label method
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
added
pr/blocked
sphuber
force-pushed
the
feature/007/custom-process-label
branch
from
8bfc496
to
6ffe0db
Compare
This method returns the string that is set as the `process_label` attribute on the nodes representing executions of the process class. By default this is the name of the process class, i.e., `ShellJob` in this case. This is not very informative as all `ShellJob` runs, regardless of the shell command it ran, will get the same label. Here we override the `_build_process_label` to include the full label of the code, which in turn will include the label (typically the name of the shell command) and the name of the computer on which is was run. An example is `ShellJob<echo@localhost>`.
sphuber
force-pushed
the
feature/007/custom-process-label
branch
from
6ffe0db
to
a754891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This method returns the string that is set as the
process_labelattribute on the nodes representing executions of the process class. By default this is the name of the process class, i.e.,ShellJobin this case. This is not very informative as allShellJobruns, regardless of the shell command it ran, will get the same label.Here we override the
_build_process_labelto include the full label of the code, which in turn will include the label (typically the name of the shell command) and the name of the computer on which is was run. An example isShellJob<echo@localhost>.